Remove callbackMesh geometry and material in DropInViewer.dispose #441
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove callbackMesh geometry and material in DropInViewer.dispose, that callbackMesh is created in init but never disposed.
I tested it as follow, edit
demo/dropin.html
to add the two lines to dispose after 10sGo to http://localhost:8080/dropin.html
the console.log doesn't show up.
I did the change in
src/DropInViewer.js
Refresh http://localhost:8080/dropin.html
the console.log
disposed
shows up.