Skip to content

Conversation

@mexon
Copy link

@mexon mexon commented Apr 7, 2011

Hi,

I've been using Plagger for years, and during that time I've made lots of changes and added new plugins and so on. I would have contributed these back earlier, but the subversion repository disappeared and I assumed the project was dead. Turns out, not quite. So I guess I'll try to slowly separate my changes and suggest them one at a time.

Here's the first, which fixes a problem I had with deduping. The deduping gets called once per entry to figure out if it should be removed, in which case it removes the entry from its list. Then it gets called once per feed, where it goes through and removes all entries that don't appear in the list. At the end of this second pass it erases the list of valid entries entirely. This means that subsequent feeds get all their entries removed, and only one feed ever gets published.

So I simply removed the clearing out of the list. It seems to work as intended. Please let me know if there was some good reason for it to clear out the list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant