-
Notifications
You must be signed in to change notification settings - Fork 16
feat: make add_dataclass_options public, separate field extraction into public helper function #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
johanneskoester
wants to merge
8
commits into
mivade:main
Choose a base branch
from
johanneskoester:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pose add_dataclass_options in the public API
mivade
reviewed
Sep 11, 2023
Owner
|
Looks like there is some typing issue that's failing on Python 3.8 but I haven't spotted what exactly it is yet. |
|
Could you please add a test like I did in my draft PR? #60 |
|
Any progress here? |
Author
|
Sorry for the delay, I completely forgot. Testcase added. |
Owner
|
Looks like we still have some CI failures around formatting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two things:
add_dataclass_optionsbecomes a public function, which fixes make _add_dataclass_options public #58I apologize for the mixed up diff. In fact,
field_to_argument_argsis just an exact copy of the inner loop that was formerly implemented inadd_dataclass_options.Also note that this PR does not introduce a breaking change, it just adds to the public API the two functions.