update tanstack start to rc version #55
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it is not a root document anymore
* main: Feature/scan error message (#51) cleanup type add github pipeline to check lint and format # Conflicts: # packages/web2/app/components/profile/errorScans/types.ts # packages/web2/app/ssr.tsx
* main: format define root in vite.config.ts to make it work properly in a monorepo
LukasFritzeDev
requested changes
Oct 7, 2025
| contextId: string, | ||
| ) { | ||
| return this.updateOne( | ||
| return this.findOneAndUpdate( |
There was a problem hiding this comment.
damit ändert sich der Return-Value der Method. War das Absicht?
There was a problem hiding this comment.
Der return type wird nie genutzt, daher erstmal egal 🤷
packages/web2/app/actions/profile.ts
Outdated
Comment on lines
51
to
54
| lastScan: serializeObjectWithIds(lastScan?.toJSON()) as unknown as | ||
| | Scan | ||
| | undefined, | ||
| lastSuccessfulScan: serializeObjectWithIds( |
There was a problem hiding this comment.
Warum braucht es hier nochmal zusätzlich serializeObjectWithIds? Sollte das nicht durch die modelOptions schon automatisch mit drin sein, wenn man toJSON aufruft? Und wenn nicht, wäre es dann vielleicht ein besserer Ansatz die toJSON-Methode in der Klasse zu überlagern?
Comment on lines
21
to
+22
| import { CronFields } from "../CronFields/CronFields.js"; | ||
| import { updateProfileCron } from "../../../actions/profile.js"; | ||
| import { updateProfileCron } from "~/actions/profile"; |
There was a problem hiding this comment.
Hm. Also ich denke wenn, sollten wir es einheitlich mit File-Suffix oder einheitlich ohne machen.
* main: Feature/add average score (#57) # Conflicts: # packages/web2/app/actions/profile.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#52