Add support for new escape sequences and Python compatible rendering #804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rals Implements \xNN (hexadecimal) and \NNN (octal) escape sequences to match Jinja2 compatibility. The \0 sequence is now handled as part of the octal system for consistency. Fixes #803 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Make clippy happy
Adds an optional pycompat_rendering flag to Environment that enables rendering values in a format compatible with Python Jinja2: - `true`/`false` render as `True`/`False` - `none` renders as `None` - Strings use Python-style escaping and quoting This addresses compatibility issues for SQL templating and other use cases where precise output format matters. The feature is disabled by default to maintain backward compatibility. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
mitsuhiko
commented
Jun 7, 2025
| fn test_pycompat_rendering_complex_case() { | ||
| let mut env = Environment::new(); | ||
|
|
||
| // Test the specific case from the issue: {{ [true, false, none, 'foo', "bar'baz", '\x13'] }} |
There was a problem hiding this comment.
The comment disagrees with the test implementation below.
| @@ -0,0 +1,72 @@ | |||
| use minijinja::{context, Environment}; | |||
There was a problem hiding this comment.
We really don't need this example here.
mitsuhiko
commented
Jun 7, 2025
minijinja/src/utils.rs
Outdated
| } | ||
|
|
||
| fn parse_hex_byte(&self, chars: &mut Chars) -> Result<u8, Error> { | ||
| let hexnum = chars.chain(repeat('\0')).take(2).collect::<String>(); |
There was a problem hiding this comment.
we should probably error if the sequence is just \x1
mitsuhiko
changed the title
|
I'm going to merge part one of it in a separate PR: #805 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements \xNN (hexadecimal) and \NNN (octal) escape sequences to match Jinja2 compatibility. The \0 sequence is now handled as part of the octal system for consistency.
This was made with Claude Code for this video: https://www.youtube.com/watch?v=sQYXZCUvpIc
Fixes #803
Fixes #785
🤖 Generated with Claude Code