Refactor Botkube stack into 9 stacks. One each for cluster - environment. #3305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: Refactor stack into 9 stacks. One each for cluster - environment. Mostly done by Claude Code aside from the Slack channel bit which I wrote.
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the Botkube Pulumi project into nine separate stacks—one per cluster-environment—introduces a dynamic Slack channel name based on the active stack, and renames the Pulumi project for consistency.
- Derive
slack_channelfromget_stack()and wire it into the Helm chart instead of a hard-coded channel - Rename project from
ol-infrastructure-botkube-applicationtool-infrastructure-botkube - Add per-environment Pulumi config files under
operations,infrastructure, andapplications, plus SOPS secrets files
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/ol_infrastructure/applications/botkube/main.py | Compute and log Slack channel from stack; inject into chart |
| src/ol_infrastructure/applications/botkube/Pulumi.yaml | Rename Pulumi project |
| src/ol_infrastructure/applications/botkube/Pulumi.operations.botkube.QA.yaml | New QA operations stack config |
| src/ol_infrastructure/applications/botkube/Pulumi.operations.botkube.Production.yaml | New Production operations stack config |
| src/ol_infrastructure/applications/botkube/Pulumi.operations.botkube.CI.yaml | New CI operations stack config |
| src/ol_infrastructure/applications/botkube/Pulumi.infrastructure.botkube.QA.yaml | New QA infrastructure stack config |
| src/ol_infrastructure/applications/botkube/Pulumi.infrastructure.botkube.Production.yaml | New Production infrastructure stack config |
| src/ol_infrastructure/applications/botkube/Pulumi.infrastructure.botkube.CI.yaml | New CI infrastructure stack config |
| src/ol_infrastructure/applications/botkube/Pulumi.applications.botkube.QA.yaml | New QA application stack config |
| src/ol_infrastructure/applications/botkube/Pulumi.applications.botkube.Production.yaml | New Production application stack config |
| src/ol_infrastructure/applications/botkube/Pulumi.applications.botkube.CI.yaml | New CI application stack config |
| src/bridge/secrets/botkube/secrets.qa.yaml | Add encrypted QA Slack tokens |
| src/bridge/secrets/botkube/secrets.production.yaml | Add encrypted Production Slack tokens |
Comments suppressed due to low confidence (2)
src/bridge/secrets/botkube/secrets.qa.yaml:1
- [nitpick] The environment suffix in this file name is lowercase (
qa), but other Pulumi config files use uppercase (QA). Consider using a consistent casing for environment identifiers across all filenames.
---
src/ol_infrastructure/applications/botkube/Pulumi.operations.botkube.QA.yaml:1
- [nitpick] There is a lot of duplication across the per-environment
operations,infrastructure, andapplicationsYAML files. You might consider generating these configs via a script or templating engine to reduce repeated boilerplate.
---
Include # in slack channel. Co-authored-by: Copilot <[email protected]>
Lowercase channel name. Co-authored-by: Copilot <[email protected]>
blarghmatey
reviewed
Jun 24, 2025
| @@ -139,6 +139,11 @@ | |||
| lambda ns: check_cluster_namespace(botkube_namespace, ns) | |||
| ) | |||
|
|
|||
| pulumi_stack = get_stack() | |||
There was a problem hiding this comment.
We have an existing utility called "parse_stack" that we typically use to pull out stack name components. That being said, we probably want to just put the slack channel in the stack config.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Refactor Botkube stack into 9 stacks. One each for cluster - environment.
Mostly done by Claude Code aside from the Slack channel bit which I wrote.
What are the relevant tickets?
mitodl/hq#7186
Description (What does it do?)
Refactor Botkube stack into 9 stacks, one per cluster X environment