fix(deps): update dependency flow-bin to ^0.269.0 #2979

renovate · 2024-05-05T02:23:01Z

This PR contains the following updates:

Package	Change	Age	Adoption	Passing	Confidence
flow-bin (changelog)	`^0.95.1` -> `^0.269.0`

Release Notes

flowtype/flow-bin (flow-bin)

[`v0.160.1`](https://redirect.github.com/flowtype/flow-bin/compare/dfdba3226b0db92254a6c11c96f2ea74b59883e7...01c86686f235cbf64

Configuration

📅 Schedule: Branch creation - "every weekend" in timezone US/Eastern, Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

renovate · 2024-05-05T02:23:02Z

⚠ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

any of the package files in this branch needs updating, or
the branch becomes conflicted, or
you click the rebase/retry checkbox if found above, or
you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: yarn.lock

/opt/containerbase/tools/corepack/0.28.0/15.14.0/node_modules/corepack/dist/lib/corepack.cjs:9398
          if (typeof this !== "object" || this === null || !(#target in this)) {
                                                             ^^^^^^^

SyntaxError: Unexpected identifier
    at Object.compileFunction (node:vm:355:18)
    at wrapSafe (node:internal/modules/cjs/loader:1022:15)
    at Module._compile (node:internal/modules/cjs/loader:1056:27)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1121:10)
    at Module.load (node:internal/modules/cjs/loader:972:32)
    at Function.Module._load (node:internal/modules/cjs/loader:813:14)
    at Module.require (node:internal/modules/cjs/loader:996:19)
    at require (node:internal/modules/cjs/helpers:92:18)
    at Object.<anonymous> (/opt/containerbase/tools/corepack/0.28.0/15.14.0/node_modules/corepack/dist/yarn.js:3:1)
    at Module._compile (node:internal/modules/cjs/loader:1092:14)

renovate · 2025-04-29T13:01:12Z

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

asajjad2 · 2025-04-30T09:07:02Z

We had added esproposal.class_static_fields=enable and esproposal.class_instance_fields=enable to ignore ES class fields syntax. These configs were deprecated and are enabled by default as mentioned here.

suppress_comment config option was also deprecated and defaults to $FlowFixMe which works because our config was the same suppress_comment= \$.\\|\n\$*\\$FlowFixMe

Also encountered a [libdef-override] error because our custom module declaration for webpack in declarations.js conflicted with Flow's built-in definition. This was fixed by adding libdef-override=off to the [lints] section of our .flowconfig file, which specifically disables this lint check while maintaining all other type checking. Since this was the only instance of this error in our codebase, this approach was safe and straightforward.

asajjad2 · 2025-05-05T09:34:24Z

In one of the previous PRs, flow was incorrectly configured to just check .cjs files. When we remove that config so it checks all .js, .jsx, .mjs, .cjs and .json files, combined with this update - we get a lot of errors. Some are simple changes from bool -> boolean, but there are other various syntax updates which we would need to make.

Another problem is that for many 3rd party modules, we don't have library definition files. From what I understand, we can run flow-typed install to generate libdefs for them. Doing this will add pre-existing libdefs for as many libraries as it can find. However, there are many libraries for which these libdefs don't exist - flow-typed marks their exports as any, but I'm not sure if we want that. The other approach would be to manually create library definitions for these libraries.

asajjad2 · 2025-05-05T10:04:47Z

@arslanashraf7 should we go with flow-typed generated libdefs or stick with only checking .cjs files?

Anas12091101 · 2025-06-04T10:39:41Z

@arslanashraf7 Should we consider transitioning our JSX files to TypeScript for static type checking, similar to MIT Learn? TypeScript has become the industry standard for type safety, and edX MFEs are also moving in that direction.
We can then remove this flow dependency

arslanashraf7 · 2025-06-17T09:31:21Z

@arslanashraf7 Should we consider transitioning our JSX files to TypeScript for static type checking, similar to MIT Learn? TypeScript has become the industry standard for type safety, and edX MFEs are also moving in that direction. We can then remove this flow dependency

I think that is a broader decision to make. We need to check if this is worth the effort since Learn is going to be the main platform moving forward. Even if we decide to transition from jsx to tsx, we should do that in a pre-planned separate ticket.

cc: @pdpinch @cachob

arslanashraf7 · 2025-09-03T08:15:21Z

Marking it blocked based on #2979 (comment)

arslanashraf7 · 2025-09-03T08:16:28Z

Marking it blocked based on #2979 (comment) + I think it is not worth doing this since we will be moving away from this app.

renovate-approve bot approved these changes May 5, 2024

View reviewed changes

odlbot had a problem deploying to xpro-ci-pr-2979 May 5, 2024 02:24 Failure

renovate bot force-pushed the renovate/flow-bin-0.x branch from 2f436ff to c77697c Compare May 6, 2024 13:22

odlbot had a problem deploying to xpro-ci-pr-2979 May 6, 2024 13:24 Failure

renovate bot force-pushed the renovate/flow-bin-0.x branch from c77697c to 57eae8b Compare May 6, 2024 16:18

odlbot had a problem deploying to xpro-ci-pr-2979 May 6, 2024 16:18 Failure

renovate bot force-pushed the renovate/flow-bin-0.x branch from 57eae8b to 1eabfdf Compare May 6, 2024 18:30

odlbot had a problem deploying to xpro-ci-pr-2979 May 6, 2024 18:31 Failure

renovate bot force-pushed the renovate/flow-bin-0.x branch from eb2a622 to c69bff5 Compare May 6, 2024 20:31

odlbot had a problem deploying to xpro-ci-pr-2979 May 6, 2024 20:32 Failure

renovate bot force-pushed the renovate/flow-bin-0.x branch from c69bff5 to d15728e Compare May 7, 2024 09:55

odlbot had a problem deploying to xpro-ci-pr-2979 May 7, 2024 09:57 Failure

renovate bot force-pushed the renovate/flow-bin-0.x branch from d15728e to 46efabb Compare May 9, 2024 22:36

renovate bot changed the title ~~fix(deps): update dependency flow-bin to ^0.235.0~~ fix(deps): update dependency flow-bin to ^0.236.0 May 9, 2024

odlbot had a problem deploying to xpro-ci-pr-2979 May 9, 2024 22:39 Failure

renovate bot force-pushed the renovate/flow-bin-0.x branch from 46efabb to c9f38d6 Compare May 14, 2024 13:29

odlbot had a problem deploying to xpro-ci-pr-2979 May 14, 2024 13:31 Failure

renovate bot force-pushed the renovate/flow-bin-0.x branch from c9f38d6 to d9713f8 Compare May 16, 2024 15:40

odlbot had a problem deploying to xpro-ci-pr-2979 May 16, 2024 15:43 Failure

renovate bot force-pushed the renovate/flow-bin-0.x branch from d9713f8 to 573bfa7 Compare May 17, 2024 11:17

odlbot had a problem deploying to xpro-ci-pr-2979 May 17, 2024 11:20 Failure

renovate bot force-pushed the renovate/flow-bin-0.x branch from 573bfa7 to 88c3f1c Compare May 17, 2024 12:26

odlbot had a problem deploying to xpro-ci-pr-2979 May 17, 2024 12:29 Failure

renovate bot force-pushed the renovate/flow-bin-0.x branch from 88c3f1c to ba0e268 Compare May 17, 2024 12:36

odlbot had a problem deploying to xpro-ci-pr-2979 May 17, 2024 12:38 Failure

renovate bot force-pushed the renovate/flow-bin-0.x branch from ba0e268 to 1428841 Compare May 18, 2024 11:56

odlbot had a problem deploying to xpro-ci-pr-2979 May 18, 2024 11:59 Failure

renovate bot force-pushed the renovate/flow-bin-0.x branch from 1428841 to e788cf8 Compare May 18, 2024 15:09

odlbot had a problem deploying to xpro-ci-pr-2979 May 18, 2024 15:12 Failure

renovate bot force-pushed the renovate/flow-bin-0.x branch 6 times, most recently from 99e7160 to 323f20d Compare April 16, 2025 16:46

renovate bot changed the title ~~fix(deps): update dependency flow-bin to ^0.267.0~~ fix(deps): update dependency flow-bin to ^0.268.0 Apr 16, 2025

renovate bot force-pushed the renovate/flow-bin-0.x branch 5 times, most recently from 2045dc5 to 54ad64f Compare April 25, 2025 07:31

renovate bot force-pushed the renovate/flow-bin-0.x branch from 54ad64f to 8b50e33 Compare April 28, 2025 15:37

fix(deps): update dependency flow-bin to ^0.269.0

6f7feff

renovate bot force-pushed the renovate/flow-bin-0.x branch from 8b50e33 to 6f7feff Compare April 29, 2025 00:49

renovate bot changed the title ~~fix(deps): update dependency flow-bin to ^0.268.0~~ fix(deps): update dependency flow-bin to ^0.269.0 Apr 29, 2025

asajjad2 self-assigned this Apr 29, 2025

chore: remove deprectated options

4869437

asajjad2 added 2 commits April 29, 2025 19:28

chore: module-file-ext correction

3f6f061

chore: ignore libdef overrides

1306161

arslanashraf7 added the Blocked label Sep 3, 2025

arslanashraf7 unassigned asajjad2 Sep 3, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(deps): update dependency flow-bin to ^0.269.0 #2979

fix(deps): update dependency flow-bin to ^0.269.0 #2979

Uh oh!

renovate bot commented May 5, 2024 •

edited

Loading

Uh oh!

renovate bot commented May 5, 2024

Uh oh!

renovate bot commented Apr 29, 2025

Uh oh!

asajjad2 commented Apr 30, 2025 •

edited

Loading

Uh oh!

asajjad2 commented May 5, 2025

Uh oh!

asajjad2 commented May 5, 2025 •

edited

Loading

Uh oh!

Anas12091101 commented Jun 4, 2025 •

edited

Loading

Uh oh!

arslanashraf7 commented Jun 17, 2025

Uh oh!

arslanashraf7 commented Sep 3, 2025

Uh oh!

arslanashraf7 commented Sep 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

fix(deps): update dependency flow-bin to ^0.269.0 #2979

Are you sure you want to change the base?

fix(deps): update dependency flow-bin to ^0.269.0 #2979

Uh oh!

Conversation

renovate bot commented May 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Release Notes

renovate bot commented May 5, 2024 •

edited

Loading