Skip to content

fix warning #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix warning #17

wants to merge 1 commit into from

Conversation

geertijewski
Copy link

solution by @515orestis #14

@nono303
Copy link

nono303 commented Dec 1, 2020

Hi,
Thanks @geertijewski for this PR!
with php8 count on uncountable object trigger an error and not a warning
testing var with is_countable before count is now mandatory

@geertijewski
Copy link
Author

Hi @nono303 thanks I was not aware of this. However I already removed the invocation of count() and replaced it with is_array(), so unless I missed something I don't think I need to amend this Pull Request

@nono303
Copy link

nono303 commented Dec 3, 2020

Hi @geertijewski,
you don't need to amend the PR
is_countable is nicer before count but require >=7.3 https://php.watch/versions/7.3#new-is_countable-function

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants