-
Notifications
You must be signed in to change notification settings - Fork 69
fixed clippy issues and cleanup of unnecessary imports #182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a8497c2
to
e5a7341
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR addresses clippy warnings and removes unnecessary imports across the codebase. The main changes involve replacing the deprecated hex::ToHex
trait with a custom hex_encode
function, updating import paths, and consolidating dependencies.
- Replaces
hex::ToHex
with customhex_encode
implementation for hex encoding operations - Renames and reorganizes multimap module from
multimap
tomultimap_ext
- Updates dependencies to use workspace-defined versions and removes deprecated crates
Reviewed Changes
Copilot reviewed 55 out of 55 changed files in this pull request and generated 5 comments.
Show a summary per file
File | Description |
---|---|
src/s3/utils.rs | Adds custom hex_encode function and removes deprecated hex/byteorder dependencies |
tests/test_upload_download_object.rs | Updates hex encoding calls to use new custom function |
src/s3/*.rs | Updates import paths from multimap to multimap_ext module |
macros/src/*.rs | Updates futures imports to use futures_util instead of futures |
common/src/*.rs | Updates rand API usage and async trait imports |
Cargo.toml | Consolidates dependencies using workspace configuration |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
e5a7341
to
47975c8
Compare
47975c8
to
d042f87
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks mostly good, let's check the display implementation on BaseUrl & Url when constructing the default & add a small safety comment on the unsafe block
1ef626c
to
d2b4d7e
Compare
d2b4d7e
to
8bc47e1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will address default on url in a follow up PR
No description provided.