Skip to content

Conversation

HJLebbink
Copy link
Member

No description provided.

@HJLebbink HJLebbink added the cleanup-rewrite Used in release doc generation label Aug 15, 2025
@HJLebbink HJLebbink requested a review from Copilot August 15, 2025 08:40
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses clippy warnings and removes unnecessary imports across the codebase. The main changes involve replacing the deprecated hex::ToHex trait with a custom hex_encode function, updating import paths, and consolidating dependencies.

  • Replaces hex::ToHex with custom hex_encode implementation for hex encoding operations
  • Renames and reorganizes multimap module from multimap to multimap_ext
  • Updates dependencies to use workspace-defined versions and removes deprecated crates

Reviewed Changes

Copilot reviewed 55 out of 55 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
src/s3/utils.rs Adds custom hex_encode function and removes deprecated hex/byteorder dependencies
tests/test_upload_download_object.rs Updates hex encoding calls to use new custom function
src/s3/*.rs Updates import paths from multimap to multimap_ext module
macros/src/*.rs Updates futures imports to use futures_util instead of futures
common/src/*.rs Updates rand API usage and async trait imports
Cargo.toml Consolidates dependencies using workspace configuration

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@HJLebbink HJLebbink marked this pull request as ready for review August 15, 2025 09:12
twuebi
twuebi previously requested changes Aug 21, 2025
Copy link
Contributor

@twuebi twuebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good, let's check the display implementation on BaseUrl & Url when constructing the default & add a small safety comment on the unsafe block

Copy link
Contributor

@twuebi twuebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will address default on url in a follow up PR

@HJLebbink HJLebbink merged commit 25d424b into minio:master Aug 26, 2025
6 checks passed
@HJLebbink HJLebbink deleted the cleanup-imports branch September 7, 2025 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup-rewrite Used in release doc generation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants