-
Notifications
You must be signed in to change notification settings - Fork 9
Add Conditional Randomization Test #359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #359 +/- ##
==========================================
+ Coverage 98.10% 99.73% +1.62%
==========================================
Files 22 20 -2
Lines 1161 1120 -41
==========================================
- Hits 1139 1117 -22
+ Misses 22 3 -19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm confused by the fact that this includes a big diff.
I made some comments specific to the CRT part.
self.n_repeat, -1 | ||
) | ||
|
||
self.importances_ = np.mean(np.abs(self.test_scores_), axis=0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand whuy you take an absolute value here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I take the absolute value because there is no guarantee that the test_score is always positive or negative.
In consequence, taking the mean can give a value close to zeros just because there is a switch between positive and negative values, which is, for me, not a desirable behaviour.
This PR is based on
