Skip to content

Conversation

@ollumcc
Copy link

@ollumcc ollumcc commented Dec 14, 2024

ive made it so its possible to add the dreamhack 2013 package without the items you get from it having unusual rarity, means that u can add cases to the unusuals file without them being handled as knives

as for the rarities, getting knives works fine with a little testing :P

thank you so much mikkokko for making this project and making it open source <3

ive made it so its possible to add the dreamhack 2013 package without the items you get from it having unusual rarity, means that u can add cases to the unusuals file without them being handled as knives
as for the rarities, getting knives works fine with a little testing :P
i made an oversight, i didnt account for "unusual_loot_lists" for example im sorry :(
previously sticker capsules with a tournament id value (basically major stickers) all got souvenir quality, thats fixed now
not sure how else to check for souvenir packages, tried checking the prefab but that didnt result in "weapon_case_souvenirpkg" as expected, it returned "weapon_case_base" likely because thats the parent prefab
@CrazyCSIW6
Copy link

over here this seems to work okay 👍

@CrazyCSIW6
Copy link

also i was about to say that the isUnusual check looks really bodgy but i wasn't looking at the right commit lol mb
anyway this looks fine, tried it and personally didn't see any glaring issues

@ollumcc
Copy link
Author

ollumcc commented Dec 26, 2024

yes dont look at the earlier commits LOL i did a few mistakes... but yea this project is really cool and im not super familiar with c++ but i wanted to contribute something hopefully useful and wanted to make the unbox stuff a bit more accurate to actual cs ^^

also i forgot to include the "EMS One Katowice 2014 Souvenir Package" to this which i think uses the same exact loot tables as the dreamhack 2013 one but im not home rn

@mikkokko
Copy link
Owner

Thanks for the PR, and sorry for taking over half a year before getting back to you.

I actually already have configurable rarity weights implemented locally, which I'll be pushing soon (Was left on hold since I wanted to confirm that the weights are actually 1:1).

I haven't properly looked into souvenirs yet (doing them properly is a ton of work), so I can't comment much on that regard. However I'd like it to work on all souvenirs and not just DH2013 before merging anything related to them. I'm also not seeing any code for handling the stickers?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants