Add --ignoreDirectoryPattern cli option #98
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's hope it gets merged before the base changes again! |
|
No worries, I have rights to merge now and most certainly can rebase as needed ;) |
| watchTreeOpts.ignoreUnreadableDir = true | ||
|
|
||
| if(argv.ignoreDirectoryPattern || argv.p) { | ||
| var match = (argv.ignoreDirectoryPattern || argv.p).match(/^\/(.*)\/([gimuy])$/); |
There was a problem hiding this comment.
#99 adds minimatch for matching, we should consider staying consistent.
levithomason
force-pushed
the
feature/ignore-directory-pattern
branch
from
bd6239d to
8428628
Compare
|
Rebased, merging. |
|
Great :) When will the version get bumped so NPM sees it? |
|
Already done, v0.19.1 should be what you're looking for. |
|
My bad; "watch" was indeed updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased version of the dead #93.