Skip to content

Conversation

phi-friday
Copy link

closes: #1428

It has been half a year since the issue was raised, but I noticed that no related PR has been created, so I gave it a try.
I believe I made minimal changes, and I expect this will remain valid unless the APIs of Valkey and Redis change drastically.

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 99.92%. Comparing base (efd1247) to head (6c52747).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/socketio/redis_manager.py 77.77% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              main    #1488      +/-   ##
===========================================
- Coverage   100.00%   99.92%   -0.08%     
===========================================
  Files           31       31              
  Lines         2530     2539       +9     
  Branches       432      432              
===========================================
+ Hits          2530     2537       +7     
- Misses           0        2       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@phi-friday
Copy link
Author

I checked it late. Tomorrow, I will check the point where the error occurred and try to make sure the tests pass. However, since I am using WSL, it might be difficult to run tests locally.

@phi-friday phi-friday force-pushed the feat-support-valkey branch from 6c52747 to a8470ce Compare August 29, 2025 13:20
@phi-friday
Copy link
Author

It looks like PR #1479 also encountered errors only in the macOS tests, just like this PR, and the same error occurred in the same test. It seems there is nothing for me to fix except for formatting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for valkey-py based client manager
2 participants