Update Get-EntraUserMembership.ps1 | Warn users if -Top or -All weren't called #1520
Conversation
Make it so that if -Top and -All aren't called, it will throw a warning to notify the user that they might not be seeing all results.
|
Learn Build status updates of commit acc92c2: ❌ Validation status: errorsPlease follow instructions here which may help to resolve issue.
For more details, please refer to the build report. Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. |
|
This link is broken.
|
| @@ -71,6 +71,9 @@ function Get-EntraUserMembership { | |||
| $params["All"] = $PSBoundParameters["All"] | |||
| } | |||
| } | |||
| elseif (-not $PSBoundParameters.ContainsKey("Top")) { | |||
There was a problem hiding this comment.
This should just be a standalone if statement like all of the other parameter checks that precede it. 👍
| @@ -71,6 +71,9 @@ function Get-EntraUserMembership { | |||
| $params["All"] = $PSBoundParameters["All"] | |||
| } | |||
| } | |||
| elseif (-not $PSBoundParameters.ContainsKey("Top")) { | |||
There was a problem hiding this comment.
Is it possible to add any additional logic to detect if the query is returning less objects than the default API limit, and only show the warning if there might be more?
There was a problem hiding this comment.
I had the exact same question but honestly just didn't have enough experience with APIs in general / the Graph API to know for sure. With that in mind though, I thought that doing the warning after receiving the response but before sending the object so that it appears along with any other warnings might work nicely enough?
Description: Make it so that if -Top and -All aren't called, it will throw a warning to notify the user that they might not be seeing all possible results.
NOTE: This is my first time making a PR, I wasn't sure where to put my CLA? And also it doesn't seem like there are any PR templates?