Skip to content

Add default --add-opens args to tooling api #1596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

Add default --add-opens args to tooling api #1596

wants to merge 1 commit into from

Conversation

@jdneo
Copy link
Member

@jdneo jdneo commented Aug 30, 2024

fix #1595

@jdneo jdneo requested a review from testforstephen as a code owner August 30, 2024 01:38
@jdneo
Copy link
Member Author

jdneo commented Aug 30, 2024

Turns out it may have some issue if the gradle java home is set to 8 or lower.

A better approach might be putting some probe logic at the server side.

@jdneo jdneo marked this pull request as draft August 30, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@testforstephen testforstephen Awaiting requested review from testforstephen testforstephen is a code owner

@chagong chagong Awaiting requested review from chagong chagong will be requested when the pull request is marked ready for review chagong is a code owner

@wenytang-ms wenytang-ms Awaiting requested review from wenytang-ms wenytang-ms will be requested when the pull request is marked ready for review wenytang-ms is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Failed to run Java: Force Java compilation with gradle extension

1 participant

@jdneo