[LSP] fix go to definition #1627
Open
+372
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
|
Keeping an eye on this... |
iisaduan
requested changes
Aug 25, 2025
internal/project/compilerhost.go
Outdated
Comment on lines
147
to
148
| // Fallback to underlying FS for files not tracked by the program (like .d.ts.map) | ||
| return fs.source.FS().ReadFile(path) |
There was a problem hiding this comment.
This shouldn't be added onto the compilerhost since d.ts.map is only used by ls features. Can you refactor so only the calls to readFile in definitionSourceMap has this fallback for d.ts.map files? It should probably also read into the snapshot's fs, instead of the underlying file system
There was a problem hiding this comment.
@iisaduan I made the change with an alternative method here. Turns out that fs.source.FS() is the snapshot FS
iisaduan
reviewed
Aug 25, 2025
|
This is working for multiple engineers internally for us 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes made it so I could go to a proper definition. This approach aligns with the way the TypeScript version of the compiler does it using VFS only and VLQ decoding.
Basically we have a situation where we have an import in a
.tsfile likein a directory like
apps/app-onein anindex.tsfile and the@latticehris an alias that should referencepackages/o11yand it does go to thepackages/o11y/dist/*.d.tsfile although not the source file implementationThis gets to the correct file and line position using VLQ decoding like the TS version does. This also enables the differentiation between "Go to Definition" and "Go to Type Definition". They both work now.
I'd love to get some feedback and modify this to fit standards that you all have.