Add Range to Hover

[Copilot]

• Merge main branch into PR branch
• Resolve merge conflicts in hover.go
• Replace manual range calculation with getRangeOfNode helper
• Resolve merge conflicts in test baselines
• Eliminate duplicate getNodeForQuickInfo calls
• Remove unnecessary comments
• Reply to comment with results

Summary

Successfully merged main branch and refactored the hover range calculation:

Key changes:

• Eliminated duplicate getNodeForQuickInfo calls by removing the getQuickInfoAndDocumentation wrapper function
• ProvideHover now directly calls getQuickInfoAndDocumentationForSymbol with the pre-calculated rangeNode
• Replaced manual range calculation with l.getRangeOfNode(rangeNode, nil, nil)
• Removed unnecessary scanner import
• Adapted to new function signatures (methods on LanguageService with receiver)
• Removed unnecessary comments - the code is self-documenting

The code now calls getNodeForQuickInfo only once per hover request, improving performance and following the same pattern used in find-all-references and other LSP features.

Fixes #1488

---

💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

[DanielRosenwasser]

@copilot Fix whatever is broken in CI

[DanielRosenwasser]

@copilot fix

[Copilot]

@copilot Fix whatever is broken in CI

Fixed the CI failures in fb261c4. The test failures were due to outdated baseline files that needed to be updated to reflect the corrected hover range calculations. All tests now pass after accepting the new baselines.

[Copilot]

@copilot fix

Fixed in fb261c4 by updating the hover baselines to reflect the corrected range calculations. All tests are now passing.

[jakebailey]

@copilot Merge main and try again. Note that there now exist helpers that can do things like getting ranges for nodes like getRangeOfNode.

[Copilot]

@copilot Merge main and try again. Note that there now exist helpers that can do things like getting ranges for nodes like getRangeOfNode.

Merged main and refactored to use the getRangeOfNode helper in e363a0b. The manual range calculation with scanner.SkipTrivia has been replaced with a call to l.getRangeOfNode(rangeNode, nil, nil), which handles trivia skipping and other edge cases more robustly. The code now follows the same pattern used in find-all-references.

[jakebailey]

well, copilot doesn't understand how submodules work in merge conflicts either, understandable

Outdated

[Copilot]

Pull Request Overview

This pull request implements a performance improvement and refactoring for the hover range calculation in the Language Server Protocol (LSP) implementation. The primary goal is to eliminate duplicate calls to getNodeForQuickInfo and ensure hover ranges accurately reflect the symbol's extent without including surrounding whitespace.

Key changes:

• Removed duplicate getNodeForQuickInfo calls by eliminating the getQuickInfoAndDocumentation wrapper function
• Implemented direct use of getRangeOfNode helper for more accurate range calculation
• Updated test baselines to reflect the new behavior where hover ranges now include the full identifier/symbol instead of just a single character

[jakebailey]

This is now exactly what I expected this to look like.

[jakebailey]

We are both review poisoned ☹️