Skip to content

Conversation

iclanton
Copy link
Member

Summary

This PR removes deprecated members and renames a few things that were slated for the next major bump.

Details

Removal of onDefineUnscopedParameters is required for the conversion to SWC (#5202).

onDefineScopedParameters may need to be removed too.

How it was tested

Built and ran tests.

Impacted documentation

API docs will need to be updated.

@github-project-automation github-project-automation bot moved this to Needs triage in Bug Triage Apr 21, 2025
@iclanton iclanton moved this from Needs triage to In Progress in Bug Triage Apr 21, 2025
@iclanton iclanton enabled auto-merge (squash) April 21, 2025 20:48
@iclanton iclanton merged commit f2616c0 into microsoft:main Apr 21, 2025
5 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Closed in Bug Triage Apr 21, 2025
@iclanton iclanton deleted the remove-deprecations branch April 21, 2025 22:13
@alexvy86
Copy link

Hi @iclanton, @dmichon-msft . This seems to have introduced a regression when running without the --local flag. When the API report files aren't up to date, the process is logging warnings but then terminating successfully (exit code 0) when it used to produce a non-zero exit code before. Reproduces consistently (in the microsoft/Fluidframework repo) with 7.52.5 but not with 7.52.4.

@D4N14L
Copy link
Member

D4N14L commented May 13, 2025

@alexvy86 good catch! I've created a PR to address this: #5226

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

4 participants