refactor: update performance test workflows to use templates #1537
+125
−167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request includes significant updates to the performance testing workflows by creating a reusable template and refactoring existing workflows to use this template. The changes aim to streamline the performance testing process and improve maintainability.
Key changes include:
Workflow Refactoring:
perf-basicandperf-advancedjobs toperf-test-basicandperf-test-advancedrespectively, and replaced their steps with a reference to the newperf-template.yamlworkflow. (.github/workflows/images.yaml)New Workflow Template:
perf-template.yamlto define common steps for performance testing, including setting up Go, logging into Azure CLI, and running performance tests. (.github/workflows/perf-template.yaml)Scheduled Workflow:
perf-schedule.yamlto run performance tests at specified intervals using the new template. (.github/workflows/perf-schedule.yaml)Cleanup:
perf.yamlworkflow file, as its functionality is now covered by the new template and refactored workflows. (.github/workflows/perf.yaml)Checklist
git commit -S -s ...). See this documentation on signing commits.Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.