Skip to content

fix: enable annotations #1471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

alexcastilio
Copy link
Contributor

@alexcastilio alexcastilio commented Mar 25, 2025

Description

Feature description: when using option enableAnnotation: true advanced metrics should only be generated for pods annotated with retina.sh: observe or pods in a namespace with that annotation.

Bug: When enableAnnotation: true advanced metrics are still being generated for all pods.

Fix:

  • add filtering to metrics module based on IPs stored on its cache
  • fixed documentation to reflect current behavior (kube-system namespace is not generating metrics by default)

Related Issue

x

Checklist

  • I have read the contributing documentation.
  • I signed and signed-off the commits (git commit -S -s ...). See this documentation on signing commits.
  • I have correctly attributed the author(s) of the code.
  • I have tested the changes locally.
  • I have followed the project's style guidelines.
  • I have updated the documentation, if necessary.
  • I have added tests, if applicable.

Screenshots (if applicable) or Testing Completed

Please add any relevant screenshots or GIFs to showcase the changes made.

Additional Notes

Add any additional notes or context about the pull request here.


Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.

Sorry, something went wrong.

@alexcastilio alexcastilio requested a review from a team as a code owner March 25, 2025 09:41
@alexcastilio alexcastilio force-pushed the alexcastilio/enable-annotations branch 2 times, most recently from 692e884 to 88bc343 Compare March 25, 2025 10:21
@alexcastilio alexcastilio force-pushed the alexcastilio/enable-annotations branch from 9391a97 to 1118da4 Compare April 11, 2025 11:25
Signed-off-by: Alex Castilio dos Santos <[email protected]>
Signed-off-by: Alex Castilio dos Santos <[email protected]>
Signed-off-by: Alex Castilio dos Santos <[email protected]>
@alexcastilio alexcastilio force-pushed the alexcastilio/enable-annotations branch from 1118da4 to feffe34 Compare April 11, 2025 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants