Integrate RN Nightly Build 0.80.0-nightly-20250317-fc7385c1e #14724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om/HariniMalothu17/react-native-windows into rn-integrate-march-harinimalothu17
chiaramooney
reviewed
Jun 2, 2025
chiaramooney
reviewed
Jun 2, 2025
chiaramooney
reviewed
Jun 2, 2025
chiaramooney
reviewed
Jun 2, 2025
chiaramooney
reviewed
Jun 2, 2025
chiaramooney
reviewed
Jun 2, 2025
chiaramooney
reviewed
Jun 2, 2025
chiaramooney
reviewed
Jun 2, 2025
chiaramooney
reviewed
Jun 2, 2025
...ges/react-native-platform-override/src/e2etest/collateral/0.62.2/flowconfig.windows.conflict
Outdated
Show resolved
Hide resolved
chiaramooney
reviewed
Jun 2, 2025
chiaramooney
reviewed
Jun 2, 2025
chiaramooney
reviewed
Jun 2, 2025
chiaramooney
reviewed
Jun 2, 2025
vnext/ReactCommon/TEMP_UntilReactCommonUpdate/react/renderer/css/CSSTokenizer.h
Outdated
Show resolved
Hide resolved
…arch-harinimalothu17
chiaramooney
reviewed
Jun 3, 2025
HariniMalothu17
force-pushed
the
rn-integrate-march-harinimalothu17
branch
from
880c2ee to
5dfcbbb
Compare
chiaramooney
reviewed
Jun 5, 2025
| @@ -71,6 +71,7 @@ | |||
| <AdditionalIncludeDirectories> | |||
| $(ReactNativeWindowsDir)stubs; | |||
| $(ReactNativeWindowsDir)\Shared\tracing; | |||
| $(FollyDir)\..\..\fast_float-6.1.4\include; | |||
There was a problem hiding this comment.
@jonthysell Ideally we'd like to change in path in line13 of CSSTokenizer to just be #include <fast_float/fast_float.h. However, after I added the directory to the AdditionalIncludeDirectories above, ReactCommon can't find the file. It can only find the file when I write out the full relative path in CSSTokenizer.h. Any ideas why that is? How come the AdditionalIncludeDirectories isn't working as expected?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Integrate RN Nightly Build 0.80.0-nightly-20250317-fc7385c1e
Commit Range
facebook/react-native@cee6339...fc7385c
Changelog
no