Skip to content

LocationObserverModule Should Be Removed #6038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
NickGerleman opened this issue Sep 20, 2020 · 2 comments · Fixed by #6054
Closed

LocationObserverModule Should Be Removed #6038

NickGerleman opened this issue Sep 20, 2020 · 2 comments · Fixed by #6054
Labels
bug help wanted
Milestone
0.64

Comments

@NickGerleman
Copy link
Contributor

This existed to serve an API no longer in React Native, and has seemingly had some issues for a while (see #6037). We should remove this. We were previously still exposing the native APIs though, so it's possible this is still in some form of use.
@ghost ghost added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Sep 20, 2020
@NickGerleman
Copy link
Contributor Author

Some existing comments on #3832

Not sure if Stellar is still using the built in native bits. Hopefully not since they've been broken for a while.

@chrisglein chrisglein added bug and removed Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) labels Sep 21, 2020
@chrisglein chrisglein added this to the 0.64 milestone Sep 21, 2020
@chrisglein
Copy link
Member

Should be safe to remove without a deprecation warning. This should have been gone awhile ago and has been broken.

@chrisglein chrisglein mentioned this issue Sep 21, 2020
Closed
NickGerleman added a commit to NickGerleman/react-native-windows that referenced this issue Sep 21, 2020
@NickGerleman
Remove LocationObserverModule
9d886b3 
Fixes microsoft#6038
@NickGerleman NickGerleman mentioned this issue Sep 21, 2020
Merged
@ghost ghost closed this as completed in #6054 Sep 22, 2020
ghost pushed a commit that referenced this issue Sep 22, 2020
@NickGerleman
Remove LocationObserverModule (#6054)
d0aa86e 
* Remove LocationObserverModule

Fixes #6038

* Change files
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted
Projects
None yet
Milestone
0.64
Development

Successfully merging a pull request may close this issue.

Remove LocationObserverModule NickGerleman/react-native-windows
2 participants
@NickGerleman @chrisglein