Skip to content

LocationObserverModule will Fail Thread Checks #6037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
NickGerleman opened this issue Sep 20, 2020 · 2 comments
Closed

LocationObserverModule will Fail Thread Checks #6037

NickGerleman opened this issue Sep 20, 2020 · 2 comments

Comments

@NickGerleman
Copy link
Contributor

This uses react::uwp::BatchingMessageQueue created on the UI thread, and will fail thread checks as BatchingMessageQueue is itself weirdly thread-affined. We also seem to be using it like it should be the NM thread, even though it's not. Likely an artifact of the MSRN migration.

@ghost ghost added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Sep 20, 2020
@NickGerleman
Copy link
Contributor Author

There's a fun comment at the bottom here

  modules.emplace_back(
      LocationObserverModule::name,
      [messageQueue]() { return std::make_unique<LocationObserverModule>(messageQueue); },
      MakeSerialQueueThread()); // TODO: figure out threading

@chrisglein
Copy link
Member

Duplicate of #6038

@chrisglein chrisglein marked this as a duplicate of #6038 Sep 21, 2020
@ghost ghost removed the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants