Skip to content

Port RNW LocationObserverModule to react-native-community/geoLocation #3832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
KAnder425 opened this issue Jan 6, 2020 · 5 comments
Closed
Labels
enhancement Extensions Tracks issues against community modules and extensions Partner: Office
Milestone

Comments

@KAnder425
Copy link
Contributor

KAnder425 commented Jan 6, 2020

Proposal: Port RNW LocationObserverModule to react-native-community/geoLocation

Summary

With the move to the 0.60 branch, navigator.geoLocation is no longer supported by react-native. It has been moved to react-native-community/geoLocation and deprecated from react-native. However, react-native-community/geoLocation doesn't support windows...yet. Our react-native-windows LocationObserver module is now 'orphaned'.

https://github.com/react-native-geolocation/react-native-geolocation

Motivation

In our UWP calendar app, the weather feature depended on navigator.geoLocation from react-native-windows. The weather feature is now broken.

Open Questions

In the interim, we might consider moving this support to react-native-windows-extended.

@ghost ghost added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Jan 6, 2020
@kmelmon
Copy link
Contributor

kmelmon commented Jan 13, 2020

The right longer term solution is to add windows support to the community module, but we haven't fully setup the infra for linking them yet.

@KAnder425 for now we could add this into react-native-windows-extended. If you're blocked on this I suggest unblocking yourself by doing this. Let us know if you need more.

@kmelmon kmelmon added Needs: Author Feedback The issue/PR needs activity from its author (label drives bot activity) and removed Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) labels Jan 13, 2020
@kmelmon
Copy link
Contributor

kmelmon commented Jan 13, 2020

@chrisglein how are we tracking adding support to the top community modules? This should likely be on the list.

@chrisglein chrisglein added the Extensions Tracks issues against community modules and extensions label Jan 14, 2020
@chrisglein
Copy link
Member

@stmoy is tracking the whole list, and we have a project board for them as well: https://github.com/microsoft/react-native-windows/projects/23
I've added it to the board.

@ghost ghost added the no-recent-activity Issue/PR has gone stale and may be closed (label applied by bot) label Jan 21, 2020
@ghost
Copy link

ghost commented Jan 21, 2020

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 14 days of this comment.

@ghost ghost closed this as completed Feb 5, 2020
@stmoy stmoy removed the Needs: Author Feedback The issue/PR needs activity from its author (label drives bot activity) label Mar 4, 2020
@ghost ghost removed the no-recent-activity Issue/PR has gone stale and may be closed (label applied by bot) label Mar 4, 2020
@stmoy stmoy reopened this Mar 4, 2020
@chrisglein chrisglein removed the vnext label Mar 18, 2020
@ghost ghost added the Invalid Triage https://github.com/microsoft/react-native-windows/wiki/Triage-Process (label applied by bot) label Apr 9, 2020
@chrisglein chrisglein added this to the Backlog milestone Jul 17, 2020
@chrisglein chrisglein removed the Invalid Triage https://github.com/microsoft/react-native-windows/wiki/Triage-Process (label applied by bot) label Jul 17, 2020
@burtonrodman
Copy link

I have submitted this pull request on react-native-geolocation to add Windows Support. Please feel free to provide any feedback.

michalchudziak/react-native-geolocation#146

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Extensions Tracks issues against community modules and extensions Partner: Office
Projects
Development

No branches or pull requests

5 participants