-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Port RNW LocationObserverModule to react-native-community/geoLocation #3832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
The right longer term solution is to add windows support to the community module, but we haven't fully setup the infra for linking them yet. @KAnder425 for now we could add this into react-native-windows-extended. If you're blocked on this I suggest unblocking yourself by doing this. Let us know if you need more. |
@chrisglein how are we tracking adding support to the top community modules? This should likely be on the list. |
@stmoy is tracking the whole list, and we have a project board for them as well: https://github.com/microsoft/react-native-windows/projects/23 |
This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 14 days of this comment. |
I have submitted this pull request on react-native-geolocation to add Windows Support. Please feel free to provide any feedback. |
Proposal: Port RNW LocationObserverModule to react-native-community/geoLocation
Summary
With the move to the 0.60 branch, navigator.geoLocation is no longer supported by react-native. It has been moved to react-native-community/geoLocation and deprecated from react-native. However, react-native-community/geoLocation doesn't support windows...yet. Our react-native-windows LocationObserver module is now 'orphaned'.
https://github.com/react-native-geolocation/react-native-geolocation
Motivation
In our UWP calendar app, the weather feature depended on navigator.geoLocation from react-native-windows. The weather feature is now broken.
Open Questions
In the interim, we might consider moving this support to react-native-windows-extended.
The text was updated successfully, but these errors were encountered: