Skip to content

fix(test-runner): use describe name in output dir #8282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 24, 2021
Merged

fix(test-runner): use describe name in output dir #8282

merged 2 commits into from
Aug 24, 2021

Conversation

JoelEinbinder
Copy link
Contributor

Fixes #8276

mxschmitt
mxschmitt reviewed Aug 18, 2021
View reviewed changes
Copy link
Member

@mxschmitt mxschmitt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: It's considered as a bug fix but might break people and lead to new generated snapshot files.

@JoelEinbinder
Copy link
Contributor Author

note: It's considered as a bug fix but might break people and lead to new generated snapshot files.

We discussed offline and decided this is not a breaking change. It changes the outputPath, but not the snapsshotPath which is what people would be committing into their repos.

@JoelEinbinder JoelEinbinder merged commit a8a3799 into microsoft:master Aug 24, 2021
@jtpio jtpio mentioned this pull request Sep 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgozman dgozman dgozman approved these changes

@mxschmitt mxschmitt mxschmitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] describe title not part of outputDir
3 participants
@JoelEinbinder @dgozman @mxschmitt