Update FFA run interface to intake context as input argument #1526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/202502 #1526 +/- ##
=================================================
Coverage ? 2.22%
=================================================
Files ? 1461
Lines ? 380819
Branches ? 4583
=================================================
Hits ? 8477
Misses ? 372269
Partials ? 73
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
liqiqiii
approved these changes
Oct 13, 2025
cfernald
approved these changes
Oct 13, 2025
kuqin12
added a commit
to kuqin12/mu_basecore
that referenced
this pull request
Oct 14, 2025
… as input argument (microsoft#1526)" This reverts commit 1cb266f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The original implementation of ArmFfaLibRun does not return register values when invoked. However, FFA_RUN is normally some operations that requires retry, i.e. after FFA_YIELD or FFA_INTERRUPTED. Thus the context returned by FFA_RUN will be eaten if this is not returned.
The change added an extra input argument to potentially return the output from monitor calls.
How This Was Tested
This is tested on QEMU SBSA and booted to UEFI shell.
Integration Instructions
One needs to pass in a pointer to context registers if the return values are needed.