feat: add scsi mode sense operation to detect write protection #1524
+80
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayank-microsoft
force-pushed
the
user/mayankkumar/scsi-mode-sense
branch
from
ff10435 to
67cde81
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/202502 #1524 +/- ##
=================================================
Coverage ? 2.22%
=================================================
Files ? 1461
Lines ? 380847
Branches ? 4583
=================================================
Hits ? 8477
Misses ? 372297
Partials ? 73
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
os-d
reviewed
Oct 9, 2025
|
edk2 PR opened in parallel: tianocore/edk2#11603 |
mayank-microsoft
force-pushed
the
user/mayankkumar/scsi-mode-sense
branch
from
67cde81 to
3588692
Compare
mayank-microsoft
force-pushed
the
user/mayankkumar/scsi-mode-sense
branch
from
3588692 to
c7c3faa
Compare
os-d
approved these changes
Oct 13, 2025
spbrogan
reviewed
Oct 14, 2025
|
|
||
| // Mode Sense 6 Byte Command returns the Write Protection status in the 3rd byte | ||
| // Bit 7 of the 3rd byte indicates the Write Protection status | ||
| *WriteProtectionEnabled = (DataBuffer[2] & 0x80) != 0; |
There was a problem hiding this comment.
where do you find this definition? I did a quick search and couldn't find it defined
There was a problem hiding this comment.
@spbrogan the SCSI stuff is not easily searchable, but copilot does a good job finding the write docs :). https://www.t10.org/ftp/t10/document.05/05-344r0.pdf see section 6.3.1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We encountered some errors where on attaching a ReadOnly disk led to write failures. We RCA'd the failure to the Volume protocol not being set to be write protected. We are proposing this change to update the blockIo protocol's media property to set Write protections based on performing a MODE SENSE operation.
For details on how to complete these options and their meaning refer to CONTRIBUTING.md.
How This Was Tested
We tested the change while booting a VM with VHD attached as read only mode and then without read-only mode. We don't encounter any errors which we were hitting earlier.
Integration Instructions
NA