Add IPv6 support in NetworkInterface feature #3957

adityagesh · 2025-08-12T09:14:04Z

Add IPv6 feature by utilizing the existing use_ipv6 runbook parameter.
IPv6 Features enables IPv6 support in VNet, Subnet and enable IPv6 on the nic interface.

The Primary IP of the VM continues to be IPv4, hence no change is required in host that is running LISA. The communication between the VMs uses IPv6.

squirrelsc · 2025-08-12T15:34:37Z

lisa/features/ipv6.py

+from lisa.feature import Feature
+
+
+class IPv6(Feature):


Add it to NetworkInterface, instead of a new feature. After that, we can deprecate the use_ipv6 on Azure runbook.

Can you please review the updated implementation? I am still testing it, just want to make sure the approach is correct.
I couldn't figure out how to add Ipv4/ipv6 in initialize environment.
I also have not yet added Ipv4 as default support for existing platforms other than Azure

squirrelsc · 2025-08-12T17:12:10Z

microsoft/testsuites/performance/networkperf.py

+            unsupported_os=[BSD, Windows],
+        ),
+    )
+    def perf_tcp_ipv6_ntttcp_sriov(self, result: TestResult) -> None:


Is there a specific reason to add perf test cases for IPv6? The IP version shouldn't have a significant performance impact.

LISA currently do not have coverage for any IPv6 scenario. Hence, I thought performance is a good place to start with.
I also expect that the perf numbers can be potentially different for ipv4 and ipv6

I don't think there's a performance concern with IPv6. Instead, you can add a functional test case to verify whether the network can communicate using IPv6.

squirrelsc · 2025-08-26T20:50:09Z

lisa/schema.py

@@ -709,6 +709,11 @@ class NetworkDataPath(str, Enum):
    Sriov = "Sriov"


+class IPVersion(str, Enum):


Can it reuse IpProtocol.ipv6 in other places, instead of creating a new enum?

squirrelsc · 2025-08-26T20:51:53Z

lisa/sut_orchestrator/azure/common.py

@@ -2274,13 +2274,27 @@ def get_primary_ip_addresses(
        nic_name = get_matched_str(network_interface.id, NIC_NAME_PATTERN)
        nic = network_client.network_interfaces.get(resource_group_name, nic_name)
        if nic.primary:
+            # Check if IPv6 is actually enabled on the NIC


Which setting determines whether IpProtocol.ipv6 is enabled?

squirrelsc · 2025-08-26T20:52:40Z

lisa/sut_orchestrator/azure/common.py

@@ -2274,13 +2274,27 @@ def get_primary_ip_addresses(
        nic_name = get_matched_str(network_interface.id, NIC_NAME_PATTERN)
        nic = network_client.network_interfaces.get(resource_group_name, nic_name)
        if nic.primary:
+            # Check if IPv6 is actually enabled on the NIC
+            # if its enabled, use it as internal ip.
+            ipv6_enabled = any(


What's the difference between this value and use_ipv6?

Yes, this is the problem I was having.
use_ipv6 is currently passed by runbook. This flow makes both internal address and public address as ipv6.
My requirement changes to

Ipv4 as public

Ipv6 as internal

IPv6 requirement is a feature rather than runbook parameter.

Can you suggest a better approach for the above?

I found four instances of use_ipv6 in RemoteNode, AzurePlatformSchema, AzureArmParameter, and NodeContext, but only AzurePlatformSchema and AzureArmParameter appear to be used. Please review the code history to understand the purpose of the other two.

To support the scenario you mentioned, please update the code to define use_ipv6_public and use_ipv6_internal, both defaulting to False.

Ack, let me rework the PR

squirrelsc · 2025-08-26T20:54:29Z

lisa/sut_orchestrator/azure/features.py

+        # All Azure VMs support synthetic and SRIOV networking
+        # All Azure VMs can support both IPv4 and IPv6 via ARM template configuration
+        return schema.NetworkInterfaceOptionSettings(
+            data_path=search_space.SetSpace(


When is this method used? There wasn’t such a method, but the SR-IOV and synthetic settings worked correctly.

squirrelsc · 2025-08-26T20:56:08Z

lisa/sut_orchestrator/azure/platform_.py

@@ -1199,6 +1199,12 @@ def _create_deployment_parameters(
        )
        arm_parameters.use_ipv6 = self._azure_runbook.use_ipv6

+        # Override IPv6 setting if environment specifically requires IPv6


The overrides of requirements should be defined in the runbook, and the runbook requirements are merged with the test requirements in lisa_runner. The Azure Platform shouldn't modify it, as that would disrupt the flow.

squirrelsc · 2025-08-26T20:57:27Z

lisa/tools/ip.py

@@ -346,6 +346,17 @@ def get_ip_address(self, nic_name: str) -> str:
        assert "ip_addr" in matched, f"not find ip address for nic {nic_name}"
        return matched["ip_addr"]

+    def get_ipv6_address(self, nic_name: str) -> str:


Add a parameter to the get_ip_address method instead of creating a new method.

squirrelsc · 2025-08-26T21:26:26Z

microsoft/testsuites/performance/common.py

-            ip=lagscope_server_ip
-            if lagscope_server_ip is not None
-            else server.internal_address
+            ip=(


When would lagscope_server_ip be empty?

That is a good question.

The definition of perf_ntttcp has parameter " lagscope_server_ip: Optional[str] = None,"
I'll get back to you

adityagesh requested review from squirrelsc and LiliDeng as code owners August 12, 2025 09:14

adityagesh force-pushed the aditya/ipv6_basic branch 2 times, most recently from 69dc31e to 9ba90cd Compare August 12, 2025 10:16

squirrelsc reviewed Aug 12, 2025

View reviewed changes

adityagesh force-pushed the aditya/ipv6_basic branch from 9ba90cd to 0ff61e7 Compare August 14, 2025 06:44

adityagesh changed the title ~~Add IPv6 Feature and Netperf test~~ Add IPv6 support in NetworkInterface feature Aug 14, 2025

adityagesh force-pushed the aditya/ipv6_basic branch 2 times, most recently from b00fb8f to e35839a Compare August 21, 2025 04:52

Add IPv6 Feature and Netperf test

dd659fb

adityagesh force-pushed the aditya/ipv6_basic branch from e35839a to dd659fb Compare August 21, 2025 05:02

Private IPv6

45b495d

adityagesh force-pushed the aditya/ipv6_basic branch from 2c0a409 to 45b495d Compare August 25, 2025 05:19

squirrelsc reviewed Aug 26, 2025

View reviewed changes

		@@ -709,6 +709,11 @@ class NetworkDataPath(str, Enum):
		Sriov = "Sriov"


		class IPVersion(str, Enum):

Add IPv6 support in NetworkInterface feature #3957

Are you sure you want to change the base?

Add IPv6 support in NetworkInterface feature #3957

Uh oh!

Conversation

adityagesh commented Aug 12, 2025

Uh oh!

squirrelsc Aug 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

adityagesh Aug 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

adityagesh Aug 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

squirrelsc Aug 12, 2025 •

edited

Loading

adityagesh Aug 13, 2025 •

edited

Loading

adityagesh Aug 27, 2025 •

edited

Loading