Allow user passed MTUs for ntttcp network perf tests. #3857
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR enables users to pass custom MTU values for Ntttcp network performance tests.
- Updated test functions in networkperf.py to accept an additional variables dictionary parameter.
- Modified perf_ntttcp in common.py to extract and apply the MTU from the provided variables.
- Updated Ntttcp performance message creation and dataclasses in ntttcp.py and messages.py to include client and server MTU fields.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| microsoft/testsuites/performance/networkperf.py | Added variables parameter to test case functions for Ntttcp performance testing. |
| microsoft/testsuites/performance/common.py | Introduced MTU extraction from variables and applied MTU settings for default and sriov NICs. |
| lisa/tools/ntttcp.py | Updated performance message functions to include client and server MTU parameters. |
| lisa/messages.py | Added MTU fields to the network performance message dataclasses. |
|
@LiliDeng please let me know if anything more needs to be done on this PR. |
|
Please hold off on this change for now. We're currently adding a unified message for ntttcp. Once that's merged, please add the new metrics to the unified message. |
SRIKKANTH
force-pushed
the
smyakam/custom_mtu_netperf/06_12_2025
branch
from
0918e8d to
7783b9f
Compare
SRIKKANTH
force-pushed
the
smyakam/custom_mtu_netperf/06_12_2025
branch
from
7783b9f to
c9262bb
Compare
SRIKKANTH
force-pushed
the
smyakam/custom_mtu_netperf/06_12_2025
branch
2 times, most recently
from
96bf6c5 to
84f05d6
Compare
Allow user passed MTUs for ntttcp network perf tests. There is a need for testing network perf with different MTU sizes. This change enables it.
SRIKKANTH
force-pushed
the
smyakam/custom_mtu_netperf/06_12_2025
branch
from
8c96840 to
f580493
Compare
SRIKKANTH
force-pushed
the
smyakam/custom_mtu_netperf/06_12_2025
branch
from
b4872d4 to
ad4c1bf
Compare
| # typical MTU values are between 576 and 9000 | ||
| # 576 is the minimum possible MTU for IPv4 and 1280 for IPv6 | ||
| # 9000 is a common value for jumbo frames on Ethernet networks | ||
| return 576 <= mtu <= 9000 |
There was a problem hiding this comment.
If someone sets the value to 570 but it runs with a different value, it should raise an exception and fail the case instead of silently using the default.
There was a problem hiding this comment.
set_mtu has this logic already.
There was a problem hiding this comment.
Based on the logic, if the MTU is out of range, the function returns false and sets MTU to None, which is unexpected. If you want set_mtu to fail via command, remove the check here.
There is a need for testing network perf with different MTU sizes.
This change enables it.