Skip to content

[Hub apps] Create the hub-app module for app registration #1489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 11, 2025

Conversation

flanakin
Copy link
Collaborator

@flanakin flanakin commented Apr 9, 2025

🛠️ Description

Creates a placeholder for the hub-app module that will eventually be used for app registration.

We don't have "registration" today, so this only covers telemetry. We will add more features over time as we flesh out the app model. This PR doesn't change the telemetry currently being used. It just adds new telemetry to track the app deployment.

Related to #1400

📷 Screenshots

Screenshot of the deployments created

📋 Checklist

🔬 How did you test this change?

  • 🤏 Lint tests
  • 🤞 PS -WhatIf / az validate
  • 👍 Manually deployed + verified
  • 💪 Unit tests
  • 🙌 Integration tests

🙋‍♀️ Do any of the following that apply?

  • 🚨 This is a breaking change.
  • 🤏 The change is less than 20 lines of code.

📑 Did you update docs/changelog.md?

  • ✅ Updated changelog (required for dev PRs)
  • ➡️ Will add log in a future PR (feature branch PRs only)
  • ❎ Log not needed (small/internal change)

📖 Did you update documentation?

  • ✅ Public docs in docs (required for dev)
  • ✅ Internal dev docs in src (required for dev)
  • ➡️ Will add docs in a future PR (feature branch PRs only)
  • ❎ Docs not needed (small/internal change)

@flanakin flanakin enabled auto-merge (squash) April 9, 2025 05:50
@flanakin flanakin changed the title Create a hub-app bicep module as a placeholder for app registration [Hub apps] Create a hub-app bicep module as a placeholder for app registration Apr 9, 2025
@flanakin flanakin changed the title [Hub apps] Create a hub-app bicep module as a placeholder for app registration [Hub apps] Create a hub-app bicep module for app registration Apr 10, 2025
@flanakin flanakin changed the title [Hub apps] Create a hub-app bicep module for app registration [Hub apps] Create the hub-app module for app registration Apr 10, 2025
@flanakin flanakin merged commit 4022002 into dev Apr 11, 2025
3 checks passed
@flanakin flanakin deleted the flanakin/dev/hubapps-appmod branch April 11, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Review 👀 PR that is ready to be reviewed Skill: Deployment Resource deployment automation via bicep or terraform Tool: FinOps hubs Data pipeline solution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants