-
Notifications
You must be signed in to change notification settings - Fork 7.7k
Fix not supported field warnings in count_tokens_openai #6987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@microsoft-github-policy-service agree |
@seunggil1 can you fix the build errors? |
@copilot can you create a PR to address the remaining issues based on this branch. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6987 +/- ##
==========================================
+ Coverage 80.96% 80.99% +0.03%
==========================================
Files 238 238
Lines 18279 18291 +12
==========================================
+ Hits 14799 14815 +16
+ Misses 3480 3476 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Why are these changes needed?
1.
OpenAIChatCompletionClient.count_tokens
(from autogen_ext.models.openai) ignores several JSON Schema fields of Tools (e.g., anyOf, default, title), printing Not supported field ... warnings and producing consistent gaps between the pre-send estimate and usage.prompt_tokens.Autogen Tool description example
Printed warning log
Changes
count_tokens_openai
Limitations
count_tokens_openai
function, so I just made it similar to other fields.2. In actual requests, Autogen omits the tools parameter when no tools are provided. But the current implementation adds +12 unconditionally, which overcounts tokens for tool-less calls.
Per OpenAI’s cookbook heuristics for tool-call counting, func_end = 12 represents the wrapper overhead that applies only when a tools array exists.
Changes
count_tokens_openai
Related issue number
Closes #6980
Checks