Add ollama chat completion client to WELL KNOWN PROVIDES #6961
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow instruction on: https://microsoft.github.io/autogen/stable//reference/python/autogen_ext.models.ollama.html#module-autogen_ext.models.ollama The client can create from config by `client = ChatCompletionClient.load_component(config)`. But on these lines ``` output = loaded_model.provider.rsplit(".", maxsplit=1) if len(output) != 2: raise ValueError("Invalid") ``` Will fail if one of provider not in well known list. This change add ollama to well known provider to fix that bug
|
@Z1m4-blu3 has created pull request on #6709 but now it is out-of-date with the base branch |
|
hi @ekzhu, could you please approve and run the workflows? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This change needed to load a model client with ollama provider
Follow instruction on: https://microsoft.github.io/autogen/stable//reference/python/autogen_ext.models.ollama.html#module-autogen_ext.models.ollama
The client can create from config by
client = ChatCompletionClient.load_component(config). But these lineswill make load process failure if the provider not in well known list.
Related issue number
I do not create issue. I am facing this issue and try to fix that first.
Checks