Change Nuget version format #5945
Conversation
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
codendone
left a comment
codendone
left a comment
There was a problem hiding this comment.
See my comment. Also, is this intended as a temporary change or long-term change?
| if(-not [String]::IsNullOrEmpty($versionTag)) | ||
| { | ||
| $formattedTag = '-' + $versionTag | ||
| $formattedTag = '-' + $versionTag + "-" + $(versionMinDate) + $paddedRevision |
There was a problem hiding this comment.
This is not SemVer compliant.
There was a problem hiding this comment.
Including the Date and Revision for the release one, or in all cases? Re-reading semver.org, if I change that to a "+" does that work? I switched because I thought that M.m.p+DateRev was not ok for the vpack code.
There was a problem hiding this comment.
Yes, switching to "+" should address the SemVer issue. I agree that vpack limitations also need to be considered (I'm not familiar enough there to know whether there is a problem).
I'm still curious if this is a temporary change or intended long-term. If the latter, is there a spec to review?
There was a problem hiding this comment.
I do intend this to be long term. I am adding the date and revision in case we need to rebuild something internal (as we have seen multiple times trying to get 2.0.0-exp2 out the door). We dont want to have to bump everything another patch because of a problem with a single metapackage. I have not put this recent-ish design change into a spec yet.
There was a problem hiding this comment.
I'm not excited about this as the long-term design. I strongly recommend a spec and reviewing that before implementing something across all components. Differences from the old 2.0 spec would be especially good to discuss.
There was a problem hiding this comment.
+stuff = build info, which is entirely informational. Whether and how this should be valued is hard to say given the lack of spec. We need spec, before doing any implementation.
RECOMMEND: Create specs/SemanticVersion.md and spell out how semver is defined/used (and of course follow up with spec review :-)
FYI per https://semver.org
<valid semver> ::= <version core>
| <version core> "-" <pre-release>
| <version core> "+" <build>
| <version core> "-" <pre-release> "+" <build>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Nuget will now follow:
M.m.p<-exp>+DateRev
A microsoft employee must use /azp run to validate using the pipelines below.
WARNING:
Comments made by azure-pipelines bot maybe inaccurate.
Please see pipeline link to verify that the build is being ran.
For status checks on the main branch, please use TransportPackage-Foundation-PR
(https://microsoft.visualstudio.com/ProjectReunion/_build?definitionId=81063&_a=summary)
and run the build against your PR branch with the default parameters.