Skip to content

Updates the telemetry activities in the StoragePickersTelemetry class to use critical data activity classes #5524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2025

Conversation

DinahK-2SO
Copy link
Contributor

This pull request updates the telemetry activity classes in the StoragePickersTelemetry class to use critical data activity classes instead of measures activity classes.

Telemetry updates:

  • Changed BEGIN_COMPLIANT_MEASURES_ACTIVITY_CLASS to BEGIN_COMPLIANT_CRITICAL_DATA_ACTIVITY_CLASS for the FileOpenPickerPickSingleFile activity.
  • Changed BEGIN_COMPLIANT_MEASURES_ACTIVITY_CLASS to BEGIN_COMPLIANT_CRITICAL_DATA_ACTIVITY_CLASS for the FileOpenPickerPickMultipleFile activity.
  • Changed BEGIN_COMPLIANT_MEASURES_ACTIVITY_CLASS to BEGIN_COMPLIANT_CRITICAL_DATA_ACTIVITY_CLASS for the FileSavePickerPickSingleFile activity.
  • Changed BEGIN_COMPLIANT_MEASURES_ACTIVITY_CLASS to BEGIN_COMPLIANT_CRITICAL_DATA_ACTIVITY_CLASS for the FolderPickerPickSingleFolder activity.

@DinahK-2SO
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link

@yeelam-gordon yeelam-gordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Dinah and Agne for the information.

Copy link
Contributor

@AgneLukoseviciute AgneLukoseviciute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Did you confirm it's showing up correctly in TRTT?

@DinahK-2SO
Copy link
Contributor Author

DinahK-2SO commented Jun 19, 2025

Looks good! Did you confirm it's showing up correctly in TRTT?

Thanks for reminding @AgneLukoseviciute ! I tried to capture the local telemetries on TRTT, but found the StoragePickersTelemetry is still logged as "Measures", and I cannot catch them in TRTT until enabling the Test Mode + Force Opt-In

👀Did I miss something?
image

I am testing this this new package built by our pipeline:
Microsoft.WindowsAppSDK.Foundation.1.8.250616001-experimental.nupkg

@DinahK-2SO
Copy link
Contributor Author

Looks good! Did you confirm it's showing up correctly in TRTT?

Thanks for reminding @AgneLukoseviciute ! I tried to capture the local telemetries on TRTT, but found the StoragePickersTelemetry is still logged as "Measures", and I cannot catch them in TRTT until enabling the Test Mode + Force Opt-In

👀Did I miss something?

Oh, I found the packaged built by nightly pipeline successfully shows the telemetry as "Critical", could be some issues with the previous pipeline run.

Thanks @AgneLukoseviciute , the telemetries are displayed as Critical. We're good to go now.
image

@DinahK-2SO DinahK-2SO merged commit 3cc8459 into main Jun 23, 2025
34 checks passed
@DinahK-2SO DinahK-2SO deleted the user/DinahK-2SO/storage_pickers__critical_log branch June 23, 2025 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants