Skip to content

Fix SNR calculate error, total_snrlevels, requirements.txt #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix SNR calculate error, total_snrlevels, requirements.txt #22

wants to merge 2 commits into from

Conversation

@drumpt
Copy link

@drumpt drumpt commented Oct 10, 2021

  • I think np.sqrt in line 68 of audiolib.py should be removed in order to get correct snr.
  • total_snrlevels should be a integer parameter in np.linspace(snr_lower, snr_upper, total_snrlevels) (line 47 of noisyspeech_synthesizer.py)
  • I removed unnecessary standard library "os" and changed glob to glob2 to accurately download libraries in requirements.txt

@ghost
Copy link

ghost commented Oct 10, 2021 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@drumpt drumpt closed this Dec 29, 2021
@drumpt drumpt reopened this Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@drumpt