fix bug - snr levels should be strict int #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Traceback (most recent call last):
File "e:/MS-SNSD-master/noisyspeech_synthesizer.py", line 125, in <module>
main(cfg._sections[args.cfg_str])
File "e:/MS-SNSD-master/noisyspeech_synthesizer.py", line 48, in main
SNR = np.linspace(snr_lower, snr_upper, total_snrlevels)
File "<__array_function__ internals>", line 6, in linspace
File ".\anaconda3\lib\site-packages\numpy\core\function_base.py", line 121, in linspace
.format(type(num)))
TypeError: object of type <class 'float'> cannot be safely interpreted as an integer.
yuribondarenko
approved these changes
Oct 28, 2020
|
While computing SNR, you take the square root of the scalar; shouldn't you avoid it because you are considering the RMS values instead of the power? |
Author
|
this is the value of SNR levels between lower and upper levels. Can only be an integer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes this bug