-
Notifications
You must be signed in to change notification settings - Fork 222
Local sealing #6966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Local sealing #6966
Conversation
This currently has a test for when a single node is chosen to recover. (infra.network.recover) |
/azp run |
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
4dd887b
to
de1a6ee
Compare
@@ -182,7 +182,7 @@ jobs: | |||
./tests.sh --output-on-failure -L unit -j$(nproc --all) -E indexing | |||
# Minimal end to end test that exercises SNP attestation verification | |||
# but works within the current 4 core budget | |||
./tests.sh --timeout 360 --output-on-failure -R code_update | |||
./tests.sh --timeout 360 --output-on-failure -R "schema_test_cft" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget to change it back?..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep just need a green CI run or 2 to be sure its actually working :/
If this fails I am officially confused (it is failing on my snp machine). But the seemingly the valid_key_different_machine.corrupt secret can always be decrypted without error. |
Add local sealing flow, to skip waiting for recovery shares when there is a previous sealed ledger secret.
This simply omits the
submit_recovery_shares
rpc, and still requires thetransition_to_open
proposal.