Skip to content
This repository was archived by the owner on Aug 22, 2024. It is now read-only.

CMakeLists.txt incorrectly detects x86 vs amd64 #699

Closed
schultetwin1 opened this issue Aug 29, 2019 · 2 comments
Closed

CMakeLists.txt incorrectly detects x86 vs amd64 #699

schultetwin1 opened this issue Aug 29, 2019 · 2 comments
Assignees
Labels
Bug Something isn't working Triage Approved The Issue has been approved by an Azure Kinect team member.

Comments

@schultetwin1
Copy link
Contributor

Describe the bug
In our CMakeLists.txt files we use the following logic to detect if we are building for x86 versus amd64.

if ("${CMAKE_SIZEOF_VOID_P}" STREQUAL "8")
    set(TARGET_ARCH "amd64")
elseif ("${CMAKE_SIZEOF_VOID_P}" STREQUAL "4")
    set(TARGET_ARCH "x86")
endif()

This works great while we are building for x86 and amd64 only. However, if we decide to support arm64 this will break.

We have not yet decided to support arm or not, but regardless, this should be fixed just in case we decide to go forward with arm support.

@schultetwin1 schultetwin1 added Bug Something isn't working Triage Approved The Issue has been approved by an Azure Kinect team member. labels Aug 29, 2019
@schultetwin1 schultetwin1 self-assigned this Aug 29, 2019
@wes-b
Copy link
Contributor

wes-b commented Apr 14, 2020

@schultetwin1 This is fixed now with the arm64 change IIRC?

@schultetwin1
Copy link
Contributor Author

You are correct! This was fixed by #1108

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Something isn't working Triage Approved The Issue has been approved by an Azure Kinect team member.
Projects
None yet
Development

No branches or pull requests

2 participants