Skip to content

Add method name and owning class name to error messages #12004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 4.10.x
Choose a base branch
from
Open

Add method name and owning class name to error messages #12004

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions core-processor/src/main/java/io/micronaut/inject/processing/DeclaredBeanElementCreator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -426,15 +426,15 @@ protected boolean visitAopMethod(BeanDefinitionVisitor visitor, MethodElement me
InterceptedMethodUtil.hasDeclaredAroundAdvice(methodAnnotationMetadata) && !classElement.isAbstract()) {
if (methodElement.isFinal()) {
if (InterceptedMethodUtil.hasDeclaredAroundAdvice(methodAnnotationMetadata)) {
throw new ProcessingException(methodElement, "Method defines AOP advice but is declared final. Change the method to be non-final in order for AOP advice to be applied.");
throw new ProcessingException(methodElement, "Method [" + methodElement.getOwningType().getName() + "::" + methodElement.getName() + "] defines AOP advice but is declared final. Change the method to be non-final in order for AOP advice to be applied.");
} else if (!methodElement.isSynthetic() && aopDefinedOnClassAndPublicMethod && isDeclaredInThisClass(methodElement)) {
throw new ProcessingException(methodElement, "Public method inherits AOP advice but is declared final. Either make the method non-public or apply AOP advice only to public methods declared on the class.");
throw new ProcessingException(methodElement, "Public method [" + methodElement.getOwningType().getName() + "::" + methodElement.getName() + "] inherits AOP advice but is declared final. Either make the method non-public or apply AOP advice only to public methods declared on the class.");
}
return false;
} else if (methodElement.isPrivate()) {
throw new ProcessingException(methodElement, "Method annotated as executable but is declared private. Change the method to be non-private in order for AOP advice to be applied.");
throw new ProcessingException(methodElement, "Method [" + methodElement.getOwningType().getName() + "::" + methodElement.getName() + "] annotated as executable but is declared private. Change the method to be non-private in order for AOP advice to be applied.");
} else if (methodElement.isStatic()) {
throw new ProcessingException(methodElement, "Method defines AOP advice but is declared static");
throw new ProcessingException(methodElement, "Method [" + methodElement.getOwningType().getName() + "::" + methodElement.getName() + "] defines AOP advice but is declared static");
}
AopProxyWriter aopProxyVisitor = getAroundAopProxyVisitor(visitor, methodElement);
visitAroundMethod(aopProxyVisitor, classElement, methodElement);
Expand Down Expand Up @@ -474,15 +474,15 @@ protected boolean isInjectPointMethod(MemberElement memberElement) {
private void staticMethodCheck(MethodElement methodElement) {
if (methodElement.isStatic()) {
if (!isExplicitlyAnnotatedAsExecutable(methodElement)) {
throw new ProcessingException(methodElement, "Static methods only allowed when annotated with @Executable");
throw new ProcessingException(methodElement, "Static methods only allowed when annotated with @Executable: [" + methodElement.getOwningType().getName() + "::" + methodElement.getName() + "]");
}
failIfMethodNotAccessible(methodElement);
}
}

private void failIfMethodNotAccessible(MethodElement methodElement) {
if (!methodElement.isAccessible(classElement)) {
throw new ProcessingException(methodElement, "Method is not accessible for the invocation. To invoke the method using reflection annotate it with @ReflectiveAccess");
throw new ProcessingException(methodElement, "Method [" + methodElement.getOwningType().getName() + "::" + methodElement.getName() + "] is not accessible for the invocation. To invoke the method using reflection annotate it with @ReflectiveAccess");
}
}

Expand Down Expand Up @@ -550,7 +550,7 @@ protected boolean visitExecutableMethod(BeanDefinitionVisitor visitor, MethodEle
// @Executable annotated on the method
// Throw error if it cannot be accessed without the reflection
if (!methodElement.isAccessible()) {
throw new ProcessingException(methodElement, "Method annotated as executable but is declared private. To invoke the method using reflection annotate it with @ReflectiveAccess");
throw new ProcessingException(methodElement, "Method [" + methodElement.getOwningType().getName() + "::" + methodElement.getName() + "] annotated as executable but is declared private. To invoke the method using reflection annotate it with @ReflectiveAccess");
}
} else if (!isDeclaredInThisClass(methodElement) && !methodElement.getDeclaringType().hasStereotype(Executable.class)) {
// @Executable not annotated on the declared class or method
Expand Down