-
Notifications
You must be signed in to change notification settings - Fork 55
Add extra checks for baggage header parsing #1010
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you very much for the PR! Could you please confirm that no Since key-values must be in pairs (the length of that array must be even), I'm not sure we should only fix this like you did and silently parse something that can be invalid. I think we should also let the user know that what they are doing is wrong. Maybe by doing something like this (without throwing an exception, just logging the issue): I think we should do three things:
What do you think? Are you up for doing these changes? |
Ah yeah we haven't actually considered any invalid cases |
Thank you for your guidance. I will try to experience a better and more complete implementation
|
Please let us know if you need any help. |
Thank you, you can help review again after I resubmit the PR |
I rebased this on |
Uh oh!
There was an error while loading. Please reload this page.