avoid IndexOutOfBoundsException

[songxiaosheng]

[jonatan-ivanov]

Thank you very much for the PR!

Could you please confirm that no ArrayIndexOutOfBoundsExeption is thrown from this component but you see a log event on DEBUG level instead?

Since key-values must be in pairs (the length of that array must be even), I'm not sure we should only fix this like you did and silently parse something that can be invalid. I think we should also let the user know that what they are doing is wrong. Maybe by doing something like this (without throwing an exception, just logging the issue): KeyValues.

I think we should do three things:

1. Apply your fix for index bounds
2. Length check to let the user know that the data is invalid
3. Add some tests
4. Do this on the 1.3.x branch so that all the supported versions will be fixed

What do you think? Are you up for doing these changes?
Also, in order to accept your changes, you should sign-off the commit, please see the DCO check failing.

/cc @marcingrzejszczak

[marcingrzejszczak]

Ah yeah we haven't actually considered any invalid cases

[songxiaosheng]

Thank you for your guidance. I will try to experience a better and more complete implementation

Thank you very much for the PR!

Could you please confirm that no ArrayIndexOutOfBoundsExeption is thrown from this component but you see a log event on DEBUG level instead?

Since key-values must be in pairs (the length of that array must be even), I'm not sure we should only fix this like you did and silently parse something that can be invalid. I think we should also let the user know that what they are doing is wrong. Maybe by doing something like this (without throwing an exception, just logging the issue): KeyValues.

I think we should do three things:

1. Apply your fix for index bounds
2. Length check to let the user know that the data is invalid
3. Add some tests
4. Do this on the 1.3.x branch so that all the supported versions will be fixed

What do you think? Are you up for doing these changes?
Also, in order to accept your changes, you should sign-off the commit, please see the DCO check failing.

/cc @marcingrzejszczak

[jonatan-ivanov]

Please let us know if you need any help.

[songxiaosheng]

Please let us know if you need any help.

Thank you, you can help review again after I resubmit the PR