Add assertion for no re-registering Kafka metrics #6119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit also copies OutputCaptureExtension to assert it. See micrometer-metricsgh-6068 Signed-off-by: Johnny Lim <[email protected]>
jonatan-ivanov
approved these changes
Apr 15, 2025
There was a problem hiding this comment.
Could you please add a permalink to the javadoc of the copied classes that tells where they were copied from?
E.g.:
Copied from: https://github.com/spring-projects/spring-boot/blob/88c9ae97b5638491964537bb5b1f7dfbea1ae047/spring-boot-project/spring-boot-test/src/main/java/org/springframework/boot/test/system/CapturedOutput.java
Also, if we want to use these in other modules, we might need to relocate them but for now I think we can keep them here.
jonatan-ivanov
added
type: task
Signed-off-by: Johnny Lim <[email protected]>
|
@jonatan-ivanov Sure, I applied your suggestion in ffb5881. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an assertion for no re-registering Kafka metrics.
This PR also copies the
OutputCaptureExtensionand its support classes from Spring Boot to assert it. While copying it, I dropped theAnsiOutputsupport as it requires more classes that don't require for this.See gh-6068