Skip to content

Publish milestones to Maven Central #5892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ dependencies {

## Milestone releases

Starting with the 1.15.0-M2 release, milestone releases and release candidates will be publish to Maven Central.
Starting with the 1.15.0-M2 release, milestone releases and release candidates will be published to Maven Central.
Note that milestone releases are for testing purposes and are not intended for production use.

## Documentation
Expand Down
8 changes: 0 additions & 8 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -262,14 +262,6 @@ subprojects {
password findProperty('SNAPSHOT_REPO_PASSWORD')
}
}
maven {
name = 'Milestone'
url = 'https://repo.spring.io/milestone'
credentials {
username findProperty('MILESTONE_REPO_USER')
password findProperty('MILESTONE_REPO_PASSWORD')
}
}
}
}

Expand Down
3 changes: 1 addition & 2 deletions docs/modules/ROOT/pages/installing.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,5 @@ Every successful https://app.circleci.com/pipelines/github/micrometer-metrics/mi
== Milestones

Milestone releases are made available for early testing purposes and are not intended for production use.
Milestone releases are published to https://repo.spring.io/milestone.
To use milestone releases, include that as a Maven repository in your build configuration.
Milestone releases are published to Maven Central.
Milestones are marked as "`pre-releases`" on GitHub, and the version has a suffix, such as `-M1` or `-RC1` (milestone 1 or release candidate 1, respectively).
3 changes: 1 addition & 2 deletions docs/src/test/resources/docs-generator-build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,7 @@
// tag::main[]
repositories {
maven { url 'https://repo.spring.io/snapshot' } // for snapshots
maven { url 'https://repo.spring.io/milestone' } // for milestones
mavenCentral() // for GA
mavenCentral() // for GA and milestones
}

ext {
Expand Down
8 changes: 0 additions & 8 deletions docs/src/test/resources/docs-generator-pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -78,13 +78,5 @@
<enabled>false</enabled>
</releases>
</repository>
<repository>
<id>spring-milestones</id>
<name>Spring Milestones</name>
<url>https://repo.spring.io/milestone</url> <!-- For Milestones -->
<snapshots>
<enabled>false</enabled>
</snapshots>
</repository>
</repositories>
</project>
4 changes: 2 additions & 2 deletions gradle/deploy.sh
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,11 @@ elif [ $CIRCLE_TAG ]; then
echo -e "Publishing Release => Branch ['$CIRCLE_BRANCH'] Tag ['$CIRCLE_TAG']"
case "$CIRCLE_TAG" in
*-M*)
./gradlew -Prelease.disableGitChecks=true -Prelease.useLastTag=true -Prelease.stage=milestone candidate publishNebulaPublicationToMilestoneRepository $SWITCHES
./gradlew -Prelease.disableGitChecks=true -Prelease.useLastTag=true -Prelease.stage=milestone candidate publishNebulaPublicationToMavenCentralRepository closeAndReleaseMavenCentralStagingRepository $SWITCHES
;;
*-RC*)
# -Prelease.stage=milestone instead of rc (should be rc), probably related to this bug: https://github.com/nebula-plugins/nebula-release-plugin/issues/213
./gradlew -Prelease.disableGitChecks=true -Prelease.useLastTag=true -Prelease.stage=milestone candidate publishNebulaPublicationToMilestoneRepository $SWITCHES
./gradlew -Prelease.disableGitChecks=true -Prelease.useLastTag=true -Prelease.stage=milestone candidate publishNebulaPublicationToMavenCentralRepository closeAndReleaseMavenCentralStagingRepository $SWITCHES
;;
*)
./gradlew -Prelease.disableGitChecks=true -Prelease.useLastTag=true -Prelease.stage=final final publishNebulaPublicationToMavenCentralRepository closeAndReleaseMavenCentralStagingRepository $SWITCHES
Expand Down