Ignore NoopMeter in firstChild scan in CompositeMeters #1442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make CompositeMeters return a meter value if at least one of the child Meters is not a NoopMeter.
shakuzen
changed the title
|
Sorry for the long time without reviewing this. Would you be willing to add tests for this along with the fix? |
|
@pivotal-jbarrett Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
Also, since it sounds like this is a bug and users should not be relying on this behavior, could you rebase the changes on the |
shakuzen
added
the
waiting for feedback
|
If you would like us to look at this PR, please provide the requested information. If the information is not provided within the next 7 days this PR will be closed. |
jonatan-ivanov
removed
waiting for feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make CompositeMeters return a meter value if at least one of the child
Meters is not a NoopMeter.
See #1441