Hamilton RNO protocol adapter #619
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
here is my attempt at a device adapter based on the Volumetric Pump device (as per @Lars-Kool split of Pressure vs Volumetric).
The code is based on @marktsuchida's HamiltonMVP and was extended to address daisy-chained MVPs and PSDs through a MM hub device (at least the devices that understand the RNO protocol).
I still have loads of work to do on this, but I thought it would be interesting to get one example of a Volumetric Pump checked in.
I'll keep chipping at it and clean up the code as (very much) needed.
Cheers,
Egor