Refactor CircularBuffer + Initial new DataBuffer #561
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oreAndDevices into data_buffer_new
|
I've tested sequence acquisitions in the GUI with regular and multi-camera configurations: everything seems to be working fine Also ran the full suite of acquisition tests in pycro-manager -- everything passes |
|
Superseded by #570 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue: #244
This PR introduces an initial draft of a new
DataBufferclass designed to extend the functionality of the existingCircularBuffer. Although still in development, these changes fully decoupleCircularBufferfrom the Core by implementing aBufferAdapterclass. It may be simpler to review and merge this PR separately from future changes, because anything that could potentially impact current functionality is contained here, and additional development ofDataBuffercan continue as an opt-in feature.Not sure if this has any interaction with #535 because the diff doesn't render