Move onPropertyChanged("Core" calls to their respective setters
#451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlambert03
commented
Mar 13, 2024
| } | ||
|
|
||
|
|
||
| void CMMCore::setTimeoutMs(long timeoutMs) |
There was a problem hiding this comment.
👀 @marktsuchida did i move this out of MMCore.h correctly?
|
Note to self: should these be asynchronous callbacks? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently, if you. call
core.setProperty("Core", ...)you will get aonPropertyChanged("Core"callback. However, if you directly call the setter method called byCorePropertyCollection::Execute, the end result is the same, but you don't get a callback. This moves the callbacks inside the setter methods. It's unfortunately more code, but it makes callbacks more consistent with internal state.