Save polarPriceId during subscription update AND select latest subscription #12

pax2678 · 2025-07-11T01:04:50Z

Fix Subscription Price ID Handling and Update Logic

Problem

When a subscription is updated in Polar, the polarPriceId in our database wasn't being updated, causing a mismatch between the actual subscription plan and what's displayed to users. This resulted in the warning message "You have an active subscription that's not shown above" being incorrectly displayed to users.

Changes Made

Updated subscription handling in webhook events:

case "subscription.updated":
  await ctx.db.patch(existingSub._id, {
    amount: args.body.data.amount,
    status: args.body.data.status,
    // Added polarPriceId update
    polarPriceId: args.body.data.price_id,
    // ... other fields
  });

Improved subscription querying to always get the latest subscription:

const subscription = await ctx.db
  .query("subscriptions")
  .withIndex("userId", (q) => q.eq("userId", user.tokenIdentifier))
  .order("desc")  // Order by createdAt in descending order
  .first();

Summary by cubic

Fixed subscription updates to save the correct polarPriceId and always select the latest subscription for each user.

Bug Fixes
- Updated the database to store the new polarPriceId when a subscription changes.
- Changed queries to always fetch the most recent subscription, preventing display mismatches.

Summary by CodeRabbit

Bug Fixes
- Ensured that the most recent subscription is always retrieved when checking user subscription status.
- Improved accuracy of subscription updates by including additional subscription details during updates.

…dated in Polar. Select the latest subscription when querying subscription based on userId.

vercel · 2025-07-11T01:04:54Z

@pax2678 is attempting to deploy a commit to the Goshen Labs Team on Vercel.

A member of the Team first needs to authorize it.

coderabbitai · 2025-07-11T01:04:58Z

Walkthrough

The changes update subscription query handlers to explicitly order results by descending creation date, ensuring the most recent subscription is retrieved. Additionally, the webhook event handler now updates the polarPriceId field when processing subscription updates. No changes were made to the signatures of exported or public entities.

Changes

File(s)	Change Summary
convex/subscriptions.ts	Added explicit ordering by creation date to subscription queries; updated webhook handler to patch `polarPriceId` on subscription updates; minor whitespace adjustments.

Poem

A hop and a skip through lines of code,
Subscriptions now ordered as stories unfold.
The latest appears, right at the top,
And price IDs patched with a bunny hop.
With whiskers twitching, I review with glee—
The code is as neat as a burrow can be! 🐇

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between dbafa74 and be0a5c0.

📒 Files selected for processing (1)

convex/subscriptions.ts (5 hunks)

🔇 Additional comments (4)

convex/subscriptions.ts (4)

201-201: LGTM: Proper ordering ensures latest subscription is retrieved.

The addition of .order("desc") ensures that the most recent subscription is always selected, which addresses the core issue mentioned in the PR objectives where outdated subscription data was causing display problems.

238-238: LGTM: Consistent ordering applied across all subscription queries.

The ordering logic is consistently applied to maintain the same behavior across different query handlers.

266-266: LGTM: Ensures fetchUserSubscription returns the latest subscription.

This change completes the consistent ordering pattern across all subscription retrieval queries.

334-334: LGTM: Critical fix for subscription synchronization.

Adding polarPriceId to the patch operation ensures that the database stays synchronized with Polar when subscription plans are updated. This directly addresses the main issue described in the PR where users saw incorrect warning messages due to mismatched subscription data.

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

pax2678 · 2025-08-28T16:06:05Z

Fixed inconsistent priceId value in metadata stored in Polar and Convex. priceId is not updated after a user changes the subscription creating confusion.

Changes Summary:

Checkout Creation (lines 52-54):

REMOVED: priceId: productPriceId, from the metadata object
RESULT: Metadata now only contains userId when creating Polar checkouts
Impact:

Polar subscriptions: Will only store userId in metadata (no priceId)
Convex subscriptions: Will only store userId in metadata (no priceId)
Price tracking: Still works via the polarPriceId field in the subscription record
User linking: Preserved via userId in metadata for webhook processing

Update the polarPriceId in Subscription table when subscription is up…

be0a5c0

…dated in Polar. Select the latest subscription when querying subscription based on userId.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Save polarPriceId during subscription update AND select latest subscription #12

Save polarPriceId during subscription update AND select latest subscription #12

Uh oh!

pax2678 commented Jul 11, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

vercel bot commented Jul 11, 2025

Uh oh!

coderabbitai bot commented Jul 11, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

pax2678 commented Aug 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Save polarPriceId during subscription update AND select latest subscription #12

Are you sure you want to change the base?

Save polarPriceId during subscription update AND select latest subscription #12

Uh oh!

Conversation

pax2678 commented Jul 11, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Fix Subscription Price ID Handling and Update Logic

Problem

Changes Made

Summary by cubic

Summary by CodeRabbit

Uh oh!

vercel bot commented Jul 11, 2025

Uh oh!

coderabbitai bot commented Jul 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

pax2678 commented Aug 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

pax2678 commented Jul 11, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jul 11, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)