Skip to content

Conversation

Deraen
Copy link
Member

@Deraen Deraen commented May 24, 2016

Fixes #69

TODO:

  • We currently use collectionFormat multi as default in other parts of code: https://github.com/metosin/ring-swagger/blob/master/src/ring/swagger/json_schema.clj#L56, per Swagger/OpenAPI spec csv should be the default
  • Coercion tests are broken, they use broken coercer function which returns matchers instead of coercer so they only run single layer of coercions instead of doing recursive coercion
  • Would be nicer to set collection-format instead of collectionFormat. Maybe json-schema should do key transformations so that snake-case can be used here?

@Deraen Deraen force-pushed the collection-format-coercion branch from e1df7ec to 7f03367 Compare May 24, 2016 18:05
@ikitommi
Copy link
Member

LGTM

@ikitommi
Copy link
Member

This should be merged?

@Deraen
Copy link
Member Author

Deraen commented Jun 23, 2016

Only if the todo items are implemented.

@ovan
Copy link

ovan commented Aug 25, 2016

@Deraen Any plans to complete this? I'd be eager to use it. I guess the best alternative now is to spec the param to string and do parsing in the app?

@Deraen Deraen self-assigned this Sep 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants