🌱 Add FKAS build to PR checks #1102
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
size/M
| value: "TRUE" | ||
| image: docker.io/golang:1.24 | ||
| imagePullPolicy: Always | ||
| - name: build-fkas |
There was a problem hiding this comment.
As mentioed offline, this docker build is not actually building versus CAPM3 branch head, but static version of CAPM3.
| - name: build-fkas | ||
| branches: | ||
| - release-1.10 | ||
| run_if_changed: "^hack/fake-apiserver/.*$" |
There was a problem hiding this comment.
This also needs to run if CAPM3 api or baremetal is changed.
There was a problem hiding this comment.
Same fix is needed for all the release branches and main.
There was a problem hiding this comment.
Yup! I accidentally pushed before I had the change saved on all files. I only added the api/ because I changed the fkas so that it doesn't use capm3 baremetal/.
There was a problem hiding this comment.
How about main? That is missing here.
peppi-lotta
force-pushed
the
peppi-lotta/add-fkas-build-pr-check
branch
3 times, most recently
from
dafcb95 to
45a555f
Compare
There was a problem hiding this comment.
1.9 is tested only, does FKAS building work there? We don't want to be submitting fixes there for this.
There was a problem hiding this comment.
Thinking this through in more detail, I realized: hack/build.sh calls make build-fkas but the build-fkas is only added to the Makefile in main branch. So this job is not actually doing anything in any of the release branches....
Questions is do we want to add fkas build check in the release brances? If yes should the fkas keep using the static CAPM3 version of should it use new dynamic style?. I can open the PRs once I know if the fkas-build should use static or dynamic CAPM3 in the existing releases
Signed-off-by: peppi-lotta <[email protected]>
peppi-lotta
force-pushed
the
peppi-lotta/add-fkas-build-pr-check
branch
from
45a555f to
81888b4
Compare
metal3-io-bot
added
size/S
Add FKAS build to PR checks runs when something changes under
./hack/fake-apiserverfile.Related PR: metal3-io/cluster-api-provider-metal3#2814