Skip to content

Remove favourite function - causing traffic #3380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ranguard
Copy link
Member

Getting favourite data on the API is called... A LOT! - this is in 24 hours

Screenshot 2025-06-14 at 13 16 33

This removes fetching/displaying fav information - I've left it in https://metacpan.org/account/favorite/list in case anyone wants to extract their old data

…ount/ for now if anyone wants their personal list
@ranguard ranguard requested a review from oalders June 14, 2025 13:54
@oalders
Copy link
Member

oalders commented Jun 14, 2025

I think this is fine as a temporary measure. I'd like to defer to @haarg on the diff, though.

Copy link

codecov bot commented Jun 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.23%. Comparing base (db5168b) to head (d24c29f).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3380      +/-   ##
==========================================
- Coverage   73.48%   73.23%   -0.26%     
==========================================
  Files          67       67              
  Lines        2346     2346              
  Branches      331      331              
==========================================
- Hits         1724     1718       -6     
- Misses        496      501       +5     
- Partials      126      127       +1     
Files with missing lines Coverage Δ
lib/MetaCPAN/Web/Model/ReleaseInfo.pm 82.05% <ø> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ranguard ranguard requested a review from haarg June 14, 2025 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants